netdev - Re: [PATCH 2/3] rcar_can: print signed IRQ #

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <558593F4.1080402@cogentembedded.com>
Date:	Sat, 20 Jun 2015 19:25:24 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Marc Kleine-Budde <mkl@...gutronix.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	wg@...ndegger.com, linux-can@...r.kernel.org,
	Linux-sh list <linux-sh@...r.kernel.org>
Subject: Re: [PATCH 2/3] rcar_can: print signed IRQ #

Hello.

On 6/20/2015 7:02 PM, Marc Kleine-Budde wrote:

>>>> Printing IRQ # using "%x" and "%u" unsigned formats isn't quite correct as
>>>> 'ndev->irq' is of  type *int*, so  the "%d" format  needs to be used instead.

>>>> While fixing this, beautify the dev_info() message in rcar_can_probe() a bit.

>>> If you change the message, why don't you make it consistent
>>> ("interrupt" vs. "IRQ")?

>>      I decided to change the message in a follow-up patch (posted afterwards).

> Please squash you patches, so that you don't modify code (or error
> messages) that you've added in a previous patch.

    I didn't add any messages.

> Marc

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in