[<prev] [next>] [day] [month] [year] [list]
Message-ID: <1435239155-14607-1-git-send-email-gilad@benyossef.com>
Date: Thu, 25 Jun 2015 16:32:35 +0300
From: Gilad Ben-Yossef <gilad@...yossef.com>
To: <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, Gilad Ben-Yossef <giladb@...hip.com>,
"Florian Fainelli" <f.fainelli@...il.com>,
Guenter Roeck <linux@...ck-us.net>,
"Andrew Lunn" <andrew@...n.ch>, Scott Feldman <sfeldma@...il.com>
Subject: [PATCH net] dsa: fix promiscuity leak on slave dev open error
DSA master netdev promiscuity counter was not being properly
decremented on slave device open error path.
Signed-off-by: Gilad Ben-Yossef <gilad@...yossef.com>
CC: Gilad Ben-Yossef <giladb@...hip.com>
CC: David S. Miller <davem@...emloft.net>
CC: Florian Fainelli <f.fainelli@...il.com>
CC: Guenter Roeck <linux@...ck-us.net>
CC: Andrew Lunn <andrew@...n.ch>
CC: Scott Feldman <sfeldma@...il.com>
---
net/dsa/slave.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 04ffad3..0917123 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -112,7 +112,7 @@ static int dsa_slave_open(struct net_device *dev)
clear_promisc:
if (dev->flags & IFF_PROMISC)
- dev_set_promiscuity(master, 0);
+ dev_set_promiscuity(master, -1);
clear_allmulti:
if (dev->flags & IFF_ALLMULTI)
dev_set_allmulti(master, -1);
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists