netdev - Re: [PATCH net] enic: fix issues in enic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150630.235655.1007982516718911399.davem@davemloft.net>
Date:	Tue, 30 Jun 2015 23:56:55 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	_govind@....com
Cc:	netdev@...r.kernel.org, ssujith@...co.com, benve@...co.com
Subject: Re: [PATCH net] enic: fix issues in enic_poll

From: Govindarajulu Varadarajan <_govind@....com>
Date: Wed,  1 Jul 2015 11:23:54 +0530

> Current code checks only rx work done to complete napi. It completely ignores
> tx work done. If we have only tx packets to clean and no rq work, we always
> napi complete instead of re-poll. Change this behavior to re-poll until
> tx work_done + rx work_done is not 0.

The existing TX behavior is correct, please do not change it.

You should never count TX work against the NAPI poll budget, it is
only for RX work.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html