netdev - Re: [PATCH net-next v1 1/1] drivers: net: xgene: Fix the compilation error "error: implicit declaration of function 'acpi_evaluate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 1 Jul 2015 12:33:20 +0530
From:	Suman Tripathi <stripathi@....com>
To:	davem@...emloft.net, netdev@...r.kernel.org
Cc:	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Keyur Chudgar <kchudgar@....com>, patches <patches@....com>,
	Iyappan Subramanian <isubramanian@....com>,
	Suman Tripathi <stripathi@....com>
Subject: Re: [PATCH net-next v1 1/1] drivers: net: xgene: Fix the compilation
 error "error: implicit declaration of function 'acpi_evaluate_integer'" in
 APM X-Gene ethernet driver.

Hi ,

Any comments on this patch .

On Wed, Jun 24, 2015 at 1:51 PM, Suman Tripathi <stripathi@....com> wrote:
> This patch guards the acpi_evaluate_interger function as it fails
> the build for NON_ACPI CONFIG.
>
> Signed-off-by: Iyappan Subramanian <isubramanian@....com>
> Signed-off-by: Suman Tripathi <stripathi@....com>
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> ---
>  drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> index 4e83d4c..70b9ef6 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> @@ -871,6 +871,7 @@ static const struct net_device_ops xgene_ndev_ops = {
>         .ndo_set_mac_address = xgene_enet_set_mac_address,
>  };
>
> +#ifdef CONFIG_ACPI
>  static int xgene_get_port_id_acpi(struct device *dev,
>                                   struct xgene_enet_pdata *pdata)
>  {
> @@ -886,6 +887,7 @@ static int xgene_get_port_id_acpi(struct device *dev,
>
>         return 0;
>  }
> +#endif
>
>  static int xgene_get_port_id_dt(struct device *dev, struct xgene_enet_pdata *pdata)
>  {
> --
> 1.8.2.1
>



-- 
Thanks,
with regards,
Suman Tripathi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html