netdev - Re: [PATCH net-next] net: macb: replace literal constant with NET_IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5593F956.4020300@certsign.ro>
Date:	Wed, 1 Jul 2015 17:29:42 +0300
From:	Nicolae Rosia <nicolae.rosia@...tsign.ro>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	Nicolas Ferre <nicolas.ferre@...el.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

On 07/01/2015 04:44 PM, Eric Dumazet wrote:
> I really doubt this adapter can process millions of packets per second ?
I was suggesting this since I was taking into consideration the comment 
from skbuff.c, "we can save several CPU cycles by avoiding having to 
disable and re-enable IRQs."
Is there a downside to this?

>
> I would rather enable GRO, it would be more useful.
I had no idea what GRO is, so I have read about it [0] and looked at a 
couple of drivers which use it. They all seem to
replace netif_receive_skb with napi_gro_receive and when there are no 
more packets in napi_pool they call napi_gro_flush.
Is it that simple?

Regards

[0] https://lwn.net/Articles/358910/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html