lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 01 Jul 2015 17:33:54 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Nicolae Rosia <nicolae.rosia@...tsign.ro> Cc: Nicolas Ferre <nicolas.ferre@...el.com>, netdev@...r.kernel.org Subject: Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN On Wed, 2015-07-01 at 17:29 +0300, Nicolae Rosia wrote: > On 07/01/2015 04:44 PM, Eric Dumazet wrote: > > I really doubt this adapter can process millions of packets per second ? > I was suggesting this since I was taking into consideration the comment > from skbuff.c, "we can save several CPU cycles by avoiding having to > disable and re-enable IRQs." > Is there a downside to this? This only matters in terms of few nano seconds per packet, so for 10Gb+ NIC anyway. Absolute noise for most NIC. > > > > > I would rather enable GRO, it would be more useful. > I had no idea what GRO is, so I have read about it [0] and looked at a > couple of drivers which use it. They all seem to > replace netif_receive_skb with napi_gro_receive and when there are no > more packets in napi_pool they call napi_gro_flush. > Is it that simple? Yes, but main question is : Do you have the hardware to test your changes ? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists