netdev - Re: [PATCH] net/tipc: initialize security state for new connection socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <559CB082.4080403@windriver.com>
Date:	Wed, 8 Jul 2015 13:09:22 +0800
From:	Ying Xue <ying.xue@...driver.com>
To:	Stephen Smalley <sds@...ho.nsa.gov>, <jon.maloy@...csson.com>
CC:	<paul@...l-moore.com>, <linux-security-module@...r.kernel.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] net/tipc: initialize security state for new connection
 socket

On 07/07/2015 09:43 PM, Stephen Smalley wrote:
> Calling connect() with an AF_TIPC socket would trigger a series
> of error messages from SELinux along the lines of:
> SELinux: Invalid class 0
> type=AVC msg=audit(1434126658.487:34500): avc:  denied  { <unprintable> }
>   for pid=292 comm="kworker/u16:5" scontext=system_u:system_r:kernel_t:s0
>   tcontext=system_u:object_r:unlabeled_t:s0 tclass=<unprintable>
>   permissive=0
> 
> This was due to a failure to initialize the security state of the new
> connection sock by the tipc code, leaving it with junk in the security
> class field and an unlabeled secid.  Add a call to security_sk_clone()
> to inherit the security state from the parent socket.
> 
> Reported-by: Tim Shearer <tim.shearer@...rturenetworks.com>
> Signed-off-by: Stephen Smalley <sds@...ho.nsa.gov>
> Acked-by: Paul Moore <paul@...l-moore.com>

Acked-by: Ying Xue <ying.xue@...driver.com>

> ---
>  net/tipc/socket.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/tipc/socket.c b/net/tipc/socket.c
> index 46b6ed5..3a7567f 100644
> --- a/net/tipc/socket.c
> +++ b/net/tipc/socket.c
> @@ -2007,6 +2007,7 @@ static int tipc_accept(struct socket *sock, struct socket *new_sock, int flags)
>  	res = tipc_sk_create(sock_net(sock->sk), new_sock, 0, 1);
>  	if (res)
>  		goto exit;
> +	security_sk_clone(sock->sk, new_sock->sk);
>  
>  	new_sk = new_sock->sk;
>  	new_tsock = tipc_sk(new_sk);
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html