netdev - Re: [PATCH] vmxnet3: prevent receive getting out of sequence on napi poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150708.233713.1843115462537095124.davem@davemloft.net>
Date:	Wed, 08 Jul 2015 23:37:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nhorman@...driver.com
Cc:	netdev@...r.kernel.org, sbhatewara@...are.com
Subject: Re: [PATCH] vmxnet3: prevent receive getting out of sequence on
 napi poll

From: Neil Horman <nhorman@...driver.com>
Date: Tue,  7 Jul 2015 14:02:18 -0400

> vmxnet3's current napi path is built to count every rx descriptor we recieve,
> and use that as a count of the napi budget.  That means its possible to return
> from a napi poll halfway through recieving a fragmented packet accross multiple
> dma descriptors.  If that happens, the next napi poll will start with the
> descriptor ring in an improper state (e.g. the first descriptor we look at may
> have the end-of-packet bit set), which will cause a BUG halt in the driver.
> 
> Fix the issue by only counting whole received packets in the napi poll and
> returning that value, rather than the descriptor count.
> 
> Tested by the reporter and myself, successfully
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>

Applied, thanks Neil.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html