netdev - Re: [PATCH] 3c59x: Fix shared IRQ handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150708.233748.252170826314642014.davem@davemloft.net>
Date:	Wed, 08 Jul 2015 23:37:48 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dvlasenk@...hat.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] 3c59x: Fix shared IRQ handling

From: Denys Vlasenko <dvlasenk@...hat.com>
Date: Tue,  7 Jul 2015 20:48:55 +0200

> As its first order of business, boomerang_interrupt() checks whether
> the device really has any pending interrupts. If it does not,
> it does nothing and returns, but it still returns IRQ_HANDLED.
> 
> This is wrong: interrupt was not handled, IRQ handlers of other
> devices sharing this IRQ line need to be called.
> 
> vortex_interrupt() has it right: it returns IRQ_NONE in this case
> via IRQ_RETVAL(0).
> 
> Do the same in boomerang_interrupt().
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>

Looks good, applied, thanks Denys.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html