netdev - RE: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Jul 2015 18:29:08 +0000
From:	Roy Pledge <roy.pledge@...escale.com>
To:	Scott Wood <scottwood@...escale.com>,
	Paul Bolle <pebolle@...cali.nl>
CC:	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management
 driver

>   return in_be32((void *)bm + offset);
> >          ^
> > [...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_out’:
> > [...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration
> > of function ‘out_be32’ [-Werror=implicit-function-declaration]
> >   out_be32((void *)bm + offset, val);
> 
> These PPCisms will need to be fixed.  LS1043A is an ARM chip with DPAA 1.0.

LS1043 (ARM, Little Endian) support is still work in progress.  The patches for that are being tested now but are based on the SDK version of the driver and will need to be massaged in order to get them applied here.  Our plan of record is to add upstream support for this at a later time.

> 
> >   ^
> > [...]/drivers/soc/fsl/qbman/bman.c: In function ‘of_fsl_bman_probe’:
> > [...]/drivers/soc/fsl/qbman/bman.c:463:17: error: ‘NO_IRQ’ undeclared
> > (first use in this function)
> >   if (err_irq == NO_IRQ) {
> 
> This isn't even a PPCism.  It's just wrong.  Compare to zero instead.

Yeah - I recall fixing this when doing the ARM port but I guess I didn't make the same change in this version.  I will address this in the next version.


> 
> -Scott