netdev - Re: [PATCH] ravb: do not invalidate cache for RX buffer twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55A639CE.2030201@cogentembedded.com>
Date:	Wed, 15 Jul 2015 13:45:34 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	netdev@...r.kernel.org
Cc:	linux-sh@...r.kernel.org
Subject: Re: [PATCH] ravb: do not invalidate cache for RX buffer twice

Hello.

On 7/15/2015 12:56 AM, Sergei Shtylyov wrote:

> First, dma_sync_single_for_cpu() shouldn't have been called in the first place
> (it's a streaming DMA API). dma_unmap_single() should have been called instead.
                             ^
    Oops, I meant comma here.

> Second, dma_unmap_single() call after handing the buffer to napi_gro_receive()
> makes little sense.

    Moreover, 'desc->dptr' may not be valid at this point...

> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>
> ---
> The patch is against Dave Miller's 'net.git' repo.

> Don't know why I missed this DMA API misuse while working on the driver. :-<

    Dave, do you want me to resend the patch with fixed up changelog?

>   drivers/net/ethernet/renesas/ravb_main.c |   10 +++-------
>   1 file changed, 3 insertions(+), 7 deletions(-)
>
> Index: net/drivers/net/ethernet/renesas/ravb_main.c
> ===================================================================
> --- net.orig/drivers/net/ethernet/renesas/ravb_main.c
> +++ net/drivers/net/ethernet/renesas/ravb_main.c
[...]
> @@ -584,9 +583,6 @@ static bool ravb_rx(struct net_device *n
>   			if (!skb)
>   				break;	/* Better luck next round. */
>   			ravb_set_buffer_align(skb);
> -			dma_unmap_single(&ndev->dev, le32_to_cpu(desc->dptr),
> -					 ALIGN(PKT_BUF_SZ, 16),
> -					 DMA_FROM_DEVICE);
>   			dma_addr = dma_map_single(&ndev->dev, skb->data,
>   						  le16_to_cpu(desc->ds_cc),
>   						  DMA_FROM_DEVICE);

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html