netdev - Re: [PATCH] ravb: do not invalidate cache for RX buffer twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55A64DDB.4010108@cogentembedded.com>
Date:	Wed, 15 Jul 2015 15:11:07 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>
Cc:	linux-sh@...r.kernel.org
Subject: Re: [PATCH] ravb: do not invalidate cache for RX buffer twice

On 7/15/2015 1:45 PM, Sergei Shtylyov wrote:

>> First, dma_sync_single_for_cpu() shouldn't have been called in the first place
>> (it's a streaming DMA API). dma_unmap_single() should have been called instead.
>                            ^
>     Oops, I meant comma here.

>> Second, dma_unmap_single() call after handing the buffer to napi_gro_receive()
>> makes little sense.

>     Moreover, 'desc->dptr' may not be valid at this point...

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

>> ---
>> The patch is against Dave Miller's 'net.git' repo.

>> Don't know why I missed this DMA API misuse while working on the driver. :-<

>     Dave, do you want me to resend the patch with fixed up changelog?

    Oops, forgot to CC Dave. :-(

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html