lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150720171252.GP13027@tarshish>
Date:	Mon, 20 Jul 2015 20:12:52 +0300
From:	Baruch Siach <baruch@...s.co.il>
To:	Cong Wang <cwang@...pensource.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: vnet: relocate netlink code section comment

Hi Cong Wang,

On Mon, Jul 20, 2015 at 10:07:00AM -0700, Cong Wang wrote:
> On Sun, Jul 19, 2015 at 12:40 AM, Baruch Siach <baruch@...s.co.il> wrote:
> > The veth_setup() routine and the VETH_FEATURES macro are also part of the
> > netlink interface (referenced from struct rtnl_link_ops). Include them under
> > the netlink code section comment.
> 
> Or just remove it? I don't think comment like this one is useful.

The veth.c file contain a few more separator comments. Would you suggest to 
remove them all?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ