[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55B131B1.10302@metafoo.de>
Date: Thu, 23 Jul 2015 20:25:53 +0200
From: Lars-Peter Clausen <lars@...afoo.de>
To: Alban Bedel <albeu@...e.fr>, linux-mips@...ux-mips.org
CC: Ralf Baechle <ralf@...ux-mips.org>,
Hauke Mehrtens <hauke@...ke-m.de>,
Rafał Miłecki <zajec5@...il.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Tejun Heo <tj@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Alexandre Courbot <gnurou@...il.com>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Florian Fainelli <florian@...nwrt.org>,
Joe Perches <joe@...ches.com>,
Daniel Walter <dwalter@...gle.com>,
Sergey Ryazanov <ryazanov.s.a@...il.com>,
Huacai Chen <chenhc@...ote.com>,
Andrew Bresticker <abrestic@...omium.org>,
James Hartley <james.hartley@...tec.com>,
Paul Burton <paul.burton@...tec.com>,
Waldemar Brodkorb <wbx@...nadk.org>,
James Hogan <james.hogan@...tec.com>,
Tomi Valkeinen <tomi.valkeinen@...com>,
Levente Kurusa <levex@...ux.com>,
abdoulaye berthe <berthe.ab@...il.com>,
Wolfram Sang <wsa@...-dreams.de>, linux-kernel@...r.kernel.org,
linux-ide@...r.kernel.org, linux-gpio@...r.kernel.org,
linux-input@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] MIPS: Remove most of the custom gpio.h
On 07/22/2015 07:33 PM, Alban Bedel wrote:
> diff --git a/arch/mips/jz4740/gpio.c b/arch/mips/jz4740/gpio.c
> index 54c80d4..3dc500c 100644
> --- a/arch/mips/jz4740/gpio.c
> +++ b/arch/mips/jz4740/gpio.c
> @@ -262,18 +262,6 @@ uint32_t jz_gpio_port_get_value(int port, uint32_t mask)
> }
> EXPORT_SYMBOL(jz_gpio_port_get_value);
>
> -int gpio_to_irq(unsigned gpio)
> -{
> - return JZ4740_IRQ_GPIO(0) + gpio;
> -}
> -EXPORT_SYMBOL_GPL(gpio_to_irq);
This need to be hooked up the gpio_to_irq() callback of the gpio_chip struct
of this driver rather than completely removing it. Otherwise this
functionality will be broken.
Similar for other platforms which implement the function.
- Lars
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists