netdev - Re: [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bB-1LcnzvEegiHQ=6OKZ3tJVkTkyENFC1Th5XjSS4CMBw@mail.gmail.com>
Date:	Thu, 23 Jul 2015 17:03:20 -0700
From:	Scott Feldman <sfeldma@...il.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	Netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>, idosch@...lanox.com,
	eladr@...lanox.com,
	"ogerlitz@...lanox.com" <ogerlitz@...lanox.com>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Thomas Graf <tgraf@...g.ch>, ast@...mgrid.com,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Daniel Borkmann <daniel@...earbox.net>,
	john fastabend <john.fastabend@...il.com>,
	"simon.horman@...ronome.com" <simon.horman@...ronome.com>,
	John Linville <linville@...driver.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Shrijeet Mukherjee <shm@...ulusnetworks.com>,
	"nhorman@...driver.com" <nhorman@...driver.com>
Subject: Re: [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs
 switchdev drivers

On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko <jiri@...nulli.us> wrote:
> This patchset introduces Mellanox Technologies Switch driver infrastructure
> and support for SwitchX-2 ASIC.
>
> The driver is divided into 3 logical parts:
> 1) Bus - implements switch bus interface. Currently only PCI bus is
>    implemented, but more buses will be added in the future. Namely I2C
>    and SGMII.
>    (patch #2)
> 2) Driver - implemements of ASIC-specific functions.
>    Currently SwitchX-2 ASIC is supported, but a plan exists to introduce
>    support for Spectrum ASIC in the near future.
>    (patch #4)
> 3) Core - infrastructure that glues buses and drivers together.
>    It implements register access logic (EMADs) and takes care of RX traps
>    and events.
>    (patch #1 and #3)
>
> Ido Schimmel (1):
>   mlxsw: Add interface to access registers and process events
>
> Jiri Pirko (3):
>   mlxsw: Introduce Mellanox switch driver core
>   mlxsw: Add PCI bus implementation
>   mlxsw: Introduce Mellanox SwitchX-2 ASIC support

This is awesome!  Reviewing...

checkpatch.pl shows 1 ERROR, bunch of >80 chars WARNs, and bunch of
CHECKs on space after cast.

On the CHECKs on space after cast, should we modify checkpatch.pl to
not flag those for drivers/net?

-scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html