netdev - Re: [PATCH] net: switchdev: restrict vid range abstraction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150729.112842.1871916445536378243.davem@davemloft.net>
Date:	Wed, 29 Jul 2015 11:28:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sfeldma@...il.com
Cc:	vivien.didelot@...oirfairelinux.com, netdev@...r.kernel.org,
	jiri@...nulli.us, f.fainelli@...il.com,
	linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com
Subject: Re: [PATCH] net: switchdev: restrict vid range abstraction

From: Scott Feldman <sfeldma@...il.com>
Date: Wed, 29 Jul 2015 00:31:44 -0700

> Since the netlink request (for example vlan add) includes the range,
> I'm not seeing how we can response with success for the satisfied
> vlans in the range, and also respond with an error for the unsatisfied
> vlans in the range.   In other words, from the netlink msgs
> perspective, we need to treat a vlan range as all-or-nothing.  So in
> your example, if hw can't add vlan 2, we fail the entire request to
> add range 2-5.  This is where the prepare phase checks to make sure
> the entire request can be satisfied before committing to hw.

This was my concern with the change as well.

The user asked for the range to be installed, so if any portion
of it cannot be done we must not make any changes to the HW
configuration and fail the entire request.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html