netdev - Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1438457782.3225.35.camel@decadent.org.uk>
Date:	Sat, 01 Aug 2015 20:36:22 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Junling Zheng <zhengjunling@...wei.com>, gregkh@...uxfoundation.org
Cc:	lizefan@...wei.com, viro@...iv.linux.org.uk, davem@...emloft.net,
	xuhanbing@...wei.com, stable@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg
 and sendmsg

On Mon, 2015-06-01 at 09:28 +0000, Junling Zheng wrote:
> Hi, Greg:
> 
> We found that after v3.10.73, recvmsg might return -EFAULT while -EINVAL
> was expected.
> 
> We tested it through the recvmsg01 testcase come from LTP testsuit. It set
> msg->msg_namelen to -1 and the recvmsg syscall returned errno 14, which is
> unexpected (errno 22 is expected):
> 
> recvmsg01    4  TFAIL  :  invalid socket length ; returned -1 (expected -1),
> errno 14 (expected 22)
> 
> Linux mainline has no this bug for commit 08adb7dab fixes it accidentally.
> However, it is too large and complex to be backported to LTS 3.10.
> 
> So, I made the following patch to fix the above problem for LTS 3.10.
[...]

It looks like the 3.2 branch has the same problem, so I've queued this
patch up there as well.  Thanks a lot.

Ben.

-- 
Ben Hutchings
One of the nice things about standards is that there are so many of them.


Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)