netdev - Re: [PATCH] net: pktgen: don't abuse current->state in pktgen_thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150804173011.GC2758@localhost.localdomain>
Date:	Tue, 4 Aug 2015 14:30:11 -0300
From:	Marcelo Ricardo Leitner <mleitner@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Huang Ying <ying.huang@...el.com>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Jan Stancek <jstancek@...hat.com>,
	Jesper Brouer <brouer@...hat.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: pktgen: don't abuse current->state in
 pktgen_thread_worker()

On Tue, Aug 04, 2015 at 07:08:27PM +0200, Oleg Nesterov wrote:
> On 08/04, Marcelo Ricardo Leitner wrote:
> >
> > On Tue, Aug 04, 2015 at 06:33:34PM +0200, Oleg Nesterov wrote:
> > > Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop
> > > code in pktgen_thread_worker()" removed (in particular) the final
> > > __set_current_state(TASK_RUNNING) and I didn't notice the previous
> > > set_current_state(TASK_INTERRUPTIBLE). This triggers the warning
> > > in __might_sleep() after return.
> > >
> > > Afaics, we can simply remove both set_current_state()'s, and we
> > > could do this a long ago right after ef87979c273a2 "pktgen: better
> > > scheduler friendliness" which changed pktgen_thread_worker() to
> > > use wait_event_interruptible_timeout().
> > >
> > > Reported-by: Huang Ying <ying.huang@...el.com>
> > > Signed-off-by: Oleg Nesterov <oleg@...hat.com>
> >
> > Interesting that it didn't happen in my tests yet per description it
> > should have. Huang, did you do anything special to trigger this?
> 
> Do you have CONFIG_DEBUG_ATOMIC_SLEEP=y ?

Ahh yes, probably not. Thanks.

  Marcelo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html