netdev - Re: [PATCH] net: pktgen: don't abuse current->state in pktgen_thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150806.235259.2089819677267479973.davem@davemloft.net>
Date:	Thu, 06 Aug 2015 23:52:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	oleg@...hat.com
Cc:	ying.huang@...el.com, ast@...mgrid.com, jstancek@...hat.com,
	brouer@...hat.com, mleitner@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: pktgen: don't abuse current->state in
 pktgen_thread_worker()

From: Oleg Nesterov <oleg@...hat.com>
Date: Tue, 4 Aug 2015 18:33:34 +0200

> Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop
> code in pktgen_thread_worker()" removed (in particular) the final
> __set_current_state(TASK_RUNNING) and I didn't notice the previous
> set_current_state(TASK_INTERRUPTIBLE). This triggers the warning
> in __might_sleep() after return.
> 
> Afaics, we can simply remove both set_current_state()'s, and we
> could do this a long ago right after ef87979c273a2 "pktgen: better
> scheduler friendliness" which changed pktgen_thread_worker() to
> use wait_event_interruptible_timeout().
> 
> Reported-by: Huang Ying <ying.huang@...el.com>
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html