netdev - Re: [PATCH] xen-netback: Allocate fraglist early to avoid complex rollback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150803.222315.50301920889896898.davem@davemloft.net>
Date:	Mon, 03 Aug 2015 22:23:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ross.lagerwall@...rix.com
Cc:	netdev@...r.kernel.org, xen-devel@...ts.xenproject.org,
	wei.liu2@...rix.com, ian.campbell@...rix.com
Subject: Re: [PATCH] xen-netback: Allocate fraglist early to avoid complex
 rollback

From: Ross Lagerwall <ross.lagerwall@...rix.com>
Date: Mon, 3 Aug 2015 15:38:03 +0100

> Determine if a fraglist is needed in the tx path, and allocate it if
> necessary before setting up the copy and map operations.
> Otherwise, undoing the copy and map operations is tricky.
> 
> This fixes a use-after-free: if allocating the fraglist failed, the copy
> and map operations that had been set up were still executed, writing
> over the data area of a freed skb.
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@...rix.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html