netdev - Re: [PATCH] net: fec: fix initial runtime PM refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150803.222358.372324734978710162.davem@davemloft.net>
Date:	Mon, 03 Aug 2015 22:23:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	l.stach@...gutronix.de
Cc:	andrew@...n.ch, u.kleine-koenig@...gutronix.de,
	netdev@...r.kernel.org, kernel@...gutronix.de,
	patchwork-lst@...gutronix.de
Subject: Re: [PATCH] net: fec: fix initial runtime PM refcount

From: Lucas Stach <l.stach@...gutronix.de>
Date: Mon,  3 Aug 2015 17:50:11 +0200

> The clocks are initially active and thus the device is marked active.
> This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend()
> call at the end of probe then leaves us with an invalid refcount of -1,
> which in turn leads to the device staying in suspended state even though
> netdev open had been called.
> 
> Fix this by initializing the refcount to be coherent with the initial
> device status.
> 
> Fixes:
> 8fff755e9f8 (net: fec: Ensure clocks are enabled while using mdio bus)
> 
> Signed-off-by: Lucas Stach <l.stach@...gutronix.de>
> ---
> Please apply this as a fix for 4.2

I'm waiting for feedback to be given wrt. the runtime-pm issues.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html