[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150806103149.GJ20890@e106497-lin.cambridge.arm.com>
Date: Thu, 6 Aug 2015 11:31:49 +0100
From: Liviu Dudau <Liviu.Dudau@....com>
To: David Miller <davem@...emloft.net>
Cc: "mlindner@...vell.com" <mlindner@...vell.com>,
"stephen@...workplumber.org" <stephen@...workplumber.org>,
"ryan.harkin@...aro.org" <ryan.harkin@...aro.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sky2: Add module parameter for passing the MAC address
On Thu, Aug 06, 2015 at 01:32:33AM +0100, David Miller wrote:
> From: Liviu Dudau <Liviu.Dudau@....com>
> Date: Wed, 5 Aug 2015 16:50:54 +0100
>
> > For designs where EEPROMs are not connected to PCI Yukon2
> > chips we need to get the MAC address from the firmware.
> > Add a module parameter called 'mac_address' for this. It
> > will be used if no DT node can be found and the B2_MAC
> > register holds an invalid value.
> >
> > Signed-off-by: Liviu Dudau <Liviu.Dudau@....com>
>
> Sorry, such module options are absolutely not allowed.
Please clarify if this is a drivers/net/ethernet policy or
that is true for the larger subsystem. There are a few
networking drivers that have a mac_addr module parameter. I
personally used drivers/net/ethernet/8390/pcnet_cs.c as inspiration
for my patch.
>
> If an invalid MAC is present, it should be set to a random
> one via eth_random_addr().
>
Understood. Stephen Hemminger has provided a patch that I can try
and I will report back with the results.
Best regards,
Liviu
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists