netdev - Re: [PATCH net-next 6/9] net: Fix up inet_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150811.115153.841476832505171489.davem@davemloft.net>
Date:	Tue, 11 Aug 2015 11:51:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dsa@...ulusnetworks.com
Cc:	netdev@...r.kernel.org, shm@...ulusnetworks.com,
	roopa@...ulusnetworks.com, gospo@...ulusnetworks.com,
	jtoppins@...ulusnetworks.com, nikolay@...ulusnetworks.com,
	ddutt@...ulusnetworks.com, hannes@...essinduktion.org,
	nicolas.dichtel@...nd.com, stephen@...workplumber.org,
	hadi@...atatu.com, ebiederm@...ssion.com, svaidya@...cade.com
Subject: Re: [PATCH net-next 6/9] net: Fix up inet_addr_type checks

From: David Ahern <dsa@...ulusnetworks.com>
Date: Tue, 11 Aug 2015 12:18:20 -0600

> The intent here was to default to current behavior and to keep the
> details of that in one place. If you prefer table id to always enter
> with the right value I can make that happen.

I think it looks better that way.

People reading individual pieces of code can tell what is happening
much more easily.

As currently structured, the have to know the internal details of a
helper function to understand what '0' means.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html