netdev - Re: [PATCH v1 2/2] drivers: net: xgene: Adding support for TSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150817.172711.1231947431645678967.davem@davemloft.net>
Date:	Mon, 17 Aug 2015 17:27:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	isubramanian@....com
Cc:	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	kchudgar@....com, patches@....com
Subject: Re: [PATCH v1 2/2] drivers: net: xgene: Adding support for TSO

From: Iyappan Subramanian <isubramanian@....com>
Date: Mon, 17 Aug 2015 14:33:05 -0700

> +			/* HW requires all header resides in the first buffer */
> +			if (skb_is_nonlinear(skb) &&
> +			    (skb_headlen(skb) < hdr_len)) {
> +				netdev_warn(ndev, "Headers are required to reside in header buffer\n");
> +				dev_kfree_skb(skb);
> +				return 0;
> +			}

You can't just drop the packet in this situation.

Instead, you must at least try to linearize the header to fit your
needs.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html