[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.10.1508171734560.5527@chino.kir.corp.google.com>
Date: Mon, 17 Aug 2015 17:35:41 -0700 (PDT)
From: David Rientjes <rientjes@...gle.com>
To: Jiang Liu <jiang.liu@...ux.intel.com>
cc: Andrew Morton <akpm@...ux-foundation.org>,
Mel Gorman <mgorman@...e.de>,
Mike Galbraith <umgwanakikbuti@...il.com>,
Peter Zijlstra <peterz@...radead.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
Tang Chen <tangchen@...fujitsu.com>, Tejun Heo <tj@...nel.org>,
Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
Jesse Brandeburg <jesse.brandeburg@...el.com>,
Shannon Nelson <shannon.nelson@...el.com>,
Carolyn Wyborny <carolyn.wyborny@...el.com>,
Don Skidmore <donald.c.skidmore@...el.com>,
Matthew Vick <matthew.vick@...el.com>,
John Ronciak <john.ronciak@...el.com>,
Mitch Williams <mitch.a.williams@...el.com>,
Tony Luck <tony.luck@...el.com>, linux-mm@...ck.org,
linux-hotplug@...r.kernel.org, linux-kernel@...r.kernel.org,
x86@...nel.org, intel-wired-lan@...ts.osuosl.org,
netdev@...r.kernel.org
Subject: Re: [Patch V3 5/9] i40e: Use numa_mem_id() to better support memoryless
node
On Mon, 17 Aug 2015, Jiang Liu wrote:
> Function i40e_clean_rx_irq() tries to reuse memory pages allocated
s/i40e_clean_rx_irq/i40e_clean_rx_irq_ps/
> from the nearest node. To better support memoryless node, use
> numa_mem_id() instead of numa_node_id() to get the nearest node with
> memory.
>
Out of curiosity, what prevents the cpu to be preempted and current_node
to no longer match numa_mem_id()?
> This change should only affect performance.
>
> Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> index 9a4f2bc70cd2..a8f618cb8eb0 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> @@ -1516,7 +1516,7 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, int budget)
> unsigned int total_rx_bytes = 0, total_rx_packets = 0;
> u16 rx_packet_len, rx_header_len, rx_sph, rx_hbo;
> u16 cleaned_count = I40E_DESC_UNUSED(rx_ring);
> - const int current_node = numa_node_id();
> + const int current_node = numa_mem_id();
> struct i40e_vsi *vsi = rx_ring->vsi;
> u16 i = rx_ring->next_to_clean;
> union i40e_rx_desc *rx_desc;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists