netdev - Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150818.114202.1167464751085554567.davem@davemloft.net>
Date:	Tue, 18 Aug 2015 11:42:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jiri@...nulli.us
Cc:	sfeldma@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] rocker: add debugfs support to dump
 internal tables

From: Jiri Pirko <jiri@...nulli.us>
Date: Tue, 18 Aug 2015 07:55:55 +0200

> Tue, Aug 18, 2015 at 12:36:17AM CEST, sfeldma@...il.com wrote:
>>+static int rocker_probe_debugfs_init(struct rocker *rocker)
>>+{
>>+	char dbg_dir_name[sizeof(rocker->hw.id) * 2 + 1];
>>+
>>+	sprintf(dbg_dir_name, "%*phN", (int)sizeof(rocker->hw.id),
>>+		&rocker->hw.id);
> 
> You can use PCI address here. Might be better.

This absolutely will not be unique in a multi-domain PCI configuration.

It is arguable whether that matters or not under qemu, but it's a bad
precedence to say that PCI addresses will be unique, they absolutely
are not unique between devices even of the same exact type.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html