netdev - Re: [PATCH 15/21] net: mac80211_hwsim: convert to using IFF_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Aug 2015 11:54:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	johannes@...solutions.net
Cc:	phil@....cc, netdev@...r.kernel.org, brouer@...hat.com
Subject: Re: [PATCH 15/21] net: mac80211_hwsim: convert to using
 IFF_NO_QUEUE

From: Johannes Berg <johannes@...solutions.net>
Date: Tue, 18 Aug 2015 10:43:55 +0200

> On Tue, 2015-08-18 at 10:30 +0200, Phil Sutter wrote:
>> Signed-off-by: Phil Sutter <phil@....cc>
>> Cc: Johannes Berg <johannes@...solutions.net>
>> ---
>>  drivers/net/wireless/mac80211_hwsim.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/wireless/mac80211_hwsim.c 
>> b/drivers/net/wireless/mac80211_hwsim.c
>> index 99e873d..a1dbcb2 100644
>> --- a/drivers/net/wireless/mac80211_hwsim.c
>> +++ b/drivers/net/wireless/mac80211_hwsim.c
>> @@ -2676,7 +2676,7 @@ static void hwsim_mon_setup(struct net_device 
>> *dev)
>>  	dev->netdev_ops = &hwsim_netdev_ops;
>>  	dev->destructor = free_netdev;
>>  	ether_setup(dev);
>> -	dev->tx_queue_len = 0;
>> +	dev->priv_flags |= IFF_NO_QUEUE;
>> 
> Fine with me; Dave, are you going to pick up the entire series
> (presumably there was one, I only got this patch)?
> 
> Note that there's no TX possible on this particular netdev anyway.

Yes, I'm going to take the full series.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html