netdev - Re: [PATCH ipsec-next] xfrm: Use VRF master index if output device is enslaved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0723F8F1-7349-45FF-BE9C-D2667DA28E0A@cumulusnetworks.com>
Date:	Wed, 19 Aug 2015 15:47:18 +0300
From:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:	David Ahern <dsa@...ulusnetworks.com>
Cc:	steffen.klassert@...unet.com, netdev@...r.kernel.org
Subject: Re: [PATCH ipsec-next] xfrm: Use VRF master index if output device is enslaved


> On Aug 18, 2015, at 6:54 PM, David Ahern <dsa@...ulusnetworks.com> wrote:
> 
> Directs route lookups to VRF table. Compiles out if NET_VRF is not
> enabled. With this patch able to successfully bring up ipsec tunnels
> in VRFs, even with duplicate network configuration (IPv4 tested).
> 
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
> ---
> net/ipv4/xfrm4_policy.c | 7 +++++--
> net/ipv6/xfrm6_policy.c | 7 +++++--
> 2 files changed, 10 insertions(+), 4 deletions(-)

I think you should use the new vrf_master_index() helper that acquires rcu because
it looks possible to call ->decode_session() without rcu read lock, e.g. in the hold_timer
function xfrm_policy_queue_process(), though I haven’t tested it and might be missing
something. :-)

Cheers,
 Nik--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html