netdev - Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8737zf8mwd.fsf@zoro.exoscale.ch>
Date:	Wed, 19 Aug 2015 14:48:18 +0200
From:	Vincent Bernat <vincent@...nat.im>
To:	Jiri Benc <jbenc@...hat.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Subject: Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

 ❦ 19 août 2015 14:38 +0200, Jiri Benc <jbenc@...hat.com> :

>> That's the main goal of this patch: advertising the peer link as
>> IFLA_LINK attribute triggers an infinite loop in userland software when
>> they follow iflink to discover network devices topology. iflink has
>> always been the index of a lower device. If a sysfs symbolic link is not
>> good enough, I can propose a new IFLA_PEER attribute instead.
>
> This would cause regression and break applications for those of us who
> started relying on the netnsid feature to match interfaces across net
> name spaces.

Yes. Unfortunately.

> This is tough. If you're going to do such thing, you would at least
> need to also introduce IFLA_PEER_NETNSID.

Yes I can.

In my opinion, the change of semantics of IFLA_LINK is a break of
API. However, I can live with it since it's easy to workaround it. It
just seemed easier to start the discussion with a patch.
-- 
Parenthesise to avoid ambiguity.
            - The Elements of Programming Style (Kernighan & Plauger)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html