netdev - Re: e1000e: possible reggresion?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1440102551.6610.65.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 20 Aug 2015 13:29:11 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tomas Papan <tomas.papan@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: e1000e: possible reggresion?

On Thu, 2015-08-20 at 21:37 +0200, Tomas Papan wrote:
> Hi there,
> 
> I’m observing a freeze with the recent kernel (4.2-rc7). Unfortunately I can’t preserver the full traces.
> There is nothing in the messages after reboot, I was just lucky one time to see it when tail -f /var/log/messages was running.
> This is the only line which I was able to get:
> 	eth1 (e1000e): transmit queue 0 timed out
> 
> I’ve got this message in the past, but the ethtool -K eth1 tso off solved that. I’m always running
> this command at the boot time since then. There is no issue with 4.2-rc4. It is hard to bisect,
> because this machine is used as headless server and it happens randomly (usually within 2 hours).
> 
> Do you have any idea how to trace it or what can I do?
> Please keep me on CC since I’m not subscribed on this list
> 
> Regards
> Tomas

I would pull latest tree from Linus and pray the bug was fixed.

My feeling is that you hit the issue fixed with

commit 83fccfc3940c4a2db90fd7e7079f5b465cd8c6af
Author: Eric Dumazet <edumazet@...gle.com>
Date:   Thu Aug 13 15:44:51 2015 -0700

    inet: fix potential deadlock in reqsk_queue_unlink()
    
    When replacing del_timer() with del_timer_sync(), I introduced
    a deadlock condition :
    
    reqsk_queue_unlink() is called from inet_csk_reqsk_queue_drop()
    
    inet_csk_reqsk_queue_drop() can be called from many contexts,
    one being the timer handler itself (reqsk_timer_handler()).
    
    In this case, del_timer_sync() loops forever.
    
    Simple fix is to test if timer is pending.
    
    Fixes: 2235f2ac75fd ("inet: fix races with reqsk timers")
    Signed-off-by: Eric Dumazet <edumazet@...gle.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html