netdev - Re: [PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnjE+pSK620seiO==uXt=gTdc_sf2PS+=5_WLXGR40-LoJkng@mail.gmail.com>
Date:	Thu, 20 Aug 2015 13:31:37 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Jesse Gross <jesse@...ira.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata.

On Tue, Aug 18, 2015 at 6:07 PM, Jesse Gross <jesse@...ira.com> wrote:
> On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar <pshelar@...ira.com> wrote:
>> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
>> index 546494d..cb2d874 100644
>> --- a/drivers/net/geneve.c
>> +++ b/drivers/net/geneve.c
>> +static int geneve_configure(struct net *net, struct net_device *dev,
>> +                           __be32 rem_addr, __u32 vni, __u8 ttl, __u8 tos,
>> +                           __u16 dst_port, bool metadata)
> [...]
>> -       if (!data[IFLA_GENEVE_ID] || !data[IFLA_GENEVE_REMOTE])
>> -               return -EINVAL;
>> +       if (metadata && rtnl_dereference(gn->collect_md_tun))
>> +               return -EEXIST;
>
> This will allow you to configure a collect_md_tun devices and normal
> devices on top of each other, even though the latter will never get
> hit in that situation.

ok. I will make them mutually exclusive.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html