netdev - Re: [PATCH v2.2 02/22] fjes: Hardware initialization routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150820.154937.1786835766548007732.davem@davemloft.net>
Date:	Thu, 20 Aug 2015 15:49:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	izumi.taku@...fujitsu.com
Cc:	netdev@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	dvhart@...radead.org, rkhan@...hat.com,
	alexander.h.duyck@...hat.com, linux-acpi@...r.kernel.org,
	joe@...ches.com, sergei.shtylyov@...entembedded.com,
	stephen@...workplumber.org, yasu.isimatu@...il.com
Subject: Re: [PATCH v2.2 02/22] fjes: Hardware initialization routine

From: Taku Izumi <izumi.taku@...fujitsu.com>
Date: Thu, 20 Aug 2015 17:46:06 +0900

> diff --git a/drivers/net/fjes/fjes.h b/drivers/net/fjes/fjes.h
> index 4622da1..15ded96 100644
> --- a/drivers/net/fjes/fjes.h
> +++ b/drivers/net/fjes/fjes.h
> @@ -28,6 +28,6 @@
>  
>  extern char fjes_driver_name[];
>  extern char fjes_driver_version[];
> -extern u32 fjes_support_mtu[];
> +extern const u32 fjes_support_mtu[];
>  
>  #endif /* FJES_H_ */

This is kind of rediculous.  Just declare it 'const' from the start in the
patch where you add it for the first time.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html