netdev - RE: [PATCH] r8169: Add values missing in @get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0835B3720019904CB8F7AA43166CEEB2F4C1FA@RTITMBSV03.realtek.com.tw>
Date:	Thu, 20 Aug 2015 02:43:14 +0000
From:	Hayes Wang <hayeswang@...ltek.com>
To:	Corinna Vinschen <vinschen@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	Francois Romieu <romieu@...zoreil.com>,
	nic_swsd <nic_swsd@...ltek.com>,
	Ivan Vecera <ivecera@...hat.com>,
	David Miller <davem@...emloft.net>
Subject: RE: [PATCH] r8169: Add values missing in @get_stats64 from HW counters

Corinna Vinschen [mailto:vinschen@...hat.com]
> Sent: Thursday, August 20, 2015 3:24 AM
[...]
> +	/*
> +	 * Versions prior to RTL_GIGA_MAC_VER_19 don't support resetting the
> +	 * tally counters.
> +	 */
> +	if (tp->mac_version >= RTL_GIGA_MAC_VER_19) {
> +		RTL_W32(CounterAddrHigh, 0);
> +		RTL_W32(CounterAddrLow, CounterReset);

I check these with our engineers, and they say the bit 6 ~ 63 should be the
valid 64 byte alignment memory address. Although you don’t want to dump
the counters, the hw may also clear the data in the memory which is indicated
by bit 6 ~ 63, when you reset the counters.

Best Regards,
Hayes