netdev - Re: [PATCH] r8169: Add values missing in @get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150820094136.GA16132@calimero.vinschen.de>
Date:	Thu, 20 Aug 2015 11:41:36 +0200
From:	Corinna Vinschen <vinschen@...hat.com>
To:	Hayes Wang <hayeswang@...ltek.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Francois Romieu <romieu@...zoreil.com>,
	nic_swsd <nic_swsd@...ltek.com>,
	Ivan Vecera <ivecera@...hat.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] r8169: Add values missing in @get_stats64 from HW
 counters

On Aug 20 02:43, Hayes Wang wrote:
> Corinna Vinschen [mailto:vinschen@...hat.com]
> > Sent: Thursday, August 20, 2015 3:24 AM
> [...]
> > +	/*
> > +	 * Versions prior to RTL_GIGA_MAC_VER_19 don't support resetting the
> > +	 * tally counters.
> > +	 */
> > +	if (tp->mac_version >= RTL_GIGA_MAC_VER_19) {
> > +		RTL_W32(CounterAddrHigh, 0);
> > +		RTL_W32(CounterAddrLow, CounterReset);
> 
> I check these with our engineers, and they say the bit 6 ~ 63 should be the
> valid 64 byte alignment memory address. Although you don’t want to dump
> the counters, the hw may also clear the data in the memory which is indicated
> by bit 6 ~ 63, when you reset the counters.

Ok, that's easy enough to implement.  What about CmdRxEnb?  Are there
chips which need this flag set to perform the counter reset?


Thanks,
Corinna

Content of type "application/pgp-signature" skipped