netdev - Re: [PATCH 0/4 net-next] enic: add devcmd2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150821.114002.1509234742678813994.davem@davemloft.net>
Date:	Fri, 21 Aug 2015 11:40:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jesse.brandeburg@...el.com
Cc:	_govind@....com, netdev@...r.kernel.org, nalreddy@...co.com,
	ssujith@...co.com, benve@...co.com
Subject: Re: [PATCH 0/4 net-next] enic: add devcmd2

From: "Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Date: Fri, 21 Aug 2015 17:19:03 +0000

> This series introduces a compile error
> drivers/net/ethernet/cisco/enic/enic_main.c: In function 'enic_probe':
> drivers/net/ethernet/cisco/enic/enic_main.c:2490:3: error: label 'err_out_vnic_unregister' used but not defined
>    goto err_out_vnic_unregister;
>    ^

Thanks I'm about to push the following to fix this:

====================
[PATCH] enic: Fix build failure with SRIOV disabled.

err_out_vnic_unregister is used regardless of whether
SRIOV is enabled or not.

Reported-by: Jesse Brandeburg <jesse.brangeburg@...el.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
---
 drivers/net/ethernet/cisco/enic/enic_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index cb1fdc3..3352d02 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -2663,8 +2663,8 @@ err_out_disable_sriov_pp:
 		pci_disable_sriov(pdev);
 		enic->priv_flags &= ~ENIC_SRIOV_ENABLED;
 	}
-err_out_vnic_unregister:
 #endif
+err_out_vnic_unregister:
 	vnic_dev_unregister(enic->vdev);
 err_out_iounmap:
 	enic_iounmap(enic);
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html