netdev - Re: [PATCH v2] net: bcmgenet: fix uncleaned dma flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Aug 2015 11:26:00 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Jaedon Shin <jaedon.shin@...il.com>,
	David Miller <davem@...emloft.net>,
	Petri Gynther <pgynther@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: bcmgenet: fix uncleaned dma flags

On 20/08/15 18:08, Jaedon Shin wrote:
> Clean the dma flags of multiq ring buffer int the interface stop
> process. This patch fixes that the genet is not running while the
> interface is re-enabled.
> 
> $ ifup eth0 - running after booting
> $ ifdown eth0
> $ ifup eth0 - not running and occur tx_timeout
> 
> The bcmgenet_dma_disable() in bcmgenet_open() do clean ring16 dma flag
> only. If the genet has multiq, the dma register is not cleaned. and
> bcmgenet_init_dma() is not done correctly. in case
> GENET_V2(tx_queues=4), tdma_ctrl has 0x1e after running
> bcmgenet_dma_disable().
> 
> Signed-off-by: Jaedon Shin <jaedon.shin@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Thanks!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html