netdev - Re: [PATCH, net-next]r8169:Disable interrupts.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150822112302.GA24519@electric-eye.fr.zoreil.com>
Date:	Sat, 22 Aug 2015 13:23:02 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Corcodel Marian <corcodel.marian@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH, net-next]r8169:Disable interrupts.

Corcodel Marian <corcodel.marian@...il.com> :
> Disable interrupts when close the interface.
> 
> 
> Signed-off-by: Corcodel Marian <corcodel.marian@...il.com>
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 6cd7226..ea461fe 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -7548,6 +7548,7 @@ static int rtl8169_close(struct net_device *dev)
>  
>  	/* Update counters before going down */
>  	rtl8169_update_counters(dev);
> +	rtl8169_irq_mask_and_ack(tp);

It's already called through
- rtl8169_close
  - rtl8169_down

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html