netdev - Re: [PATCH v2 net-next] r8169: Add values missing in @get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150822112334.GB24519@electric-eye.fr.zoreil.com>
Date:	Sat, 22 Aug 2015 13:23:34 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	netdev@...r.kernel.org, Hayes Wang <hayeswang@...ltek.com>,
	Ivan Vecera <ivecera@...hat.com>,
	David Miller <davem@...emloft.net>,
	nic_swsd <nic_swsd@...ltek.com>
Subject: Re: [PATCH v2 net-next] r8169: Add values missing in @get_stats64
 from HW counters

Corinna Vinschen <vinschen@...hat.com> :
[...]
> That won't happen with the current patch because only
> rtl8169_reset_counters would print a log message, it's only called from
> open, and open occurs rather seldom.  Atop of that the code only tries
> to reset counters on HW supporting it, and only if resetting on the HW
> fails, there will be a log message at all.  There's no reasonable chance
> that failing to reset the counters will lead to log flooding.

Thanks for reformulating it. We are in violent agreement here.

[...]
> I'm not trying to avoid work, I'm trying to understand.
> 
> As far as I see it failing to reset the counters has no impact on the
> viability of the code.  It's still working with offsets and if the
> offset is 0 or non-0, the user space won't see the difference in the
> values returned by @get_stats64.  Successful resetting the counters is
> just a bonus.

Sorry, my english was really bad:

the code should propagate failure when rtl8169_reset_counters and
rtl8169_update_counters *simultaneously* fail.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html