netdev - Re: [PATCH] net: phy: add locking to phy_read_mmd_indirect()/phy_write_mmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Aug 2015 16:31:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	rmk+kernel@....linux.org.uk, netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: add locking to
 phy_read_mmd_indirect()/phy_write_mmd_indirect()

From: Florian Fainelli <f.fainelli@...il.com>
Date: Tue, 25 Aug 2015 07:08:24 -0700

> Le 08/25/15 01:49, Russell King a écrit :
>> The phy layer is missing locking for the above two functions - it
>> has been observed that two threads (userspace and the phy worker
>> thread) can race, entering the bus ->write or ->read functions
>> simultaneously.
>> 
>> This causes the FEC driver to initialise a completion while another
>> thread is waiting on it or while the interrupt is calling complete()
>> on it, which causes spinlock unlock-without-lock, spinlock lockups,
>> and completion timeouts.
>> 
>> Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
> 
> Acked-by: Florian Fainelli <f.fainelli@...il.com>
> Fixes: a59a4d192 ("phy: add the EEE support and the way to access to the
> MMD registers.")
> Fixes: 0c1d77dfb ("net: libphy: Add phy specific function to access mmd
> phy registers")

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html