netdev - Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150827.154202.1831965840563413727.davem@davemloft.net>
Date:	Thu, 27 Aug 2015 15:42:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org, jhs@...atatu.com,
	stephen@...workplumber.org
Subject: Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc
 to inappropriate ones

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Thu, 27 Aug 2015 15:39:12 -0700

> On Thu, Aug 27, 2015 at 3:30 PM, David Miller <davem@...emloft.net> wrote:
>> I don't like this.
>>
>> The situation is that some sophisticated qdiscs can function without
>> explicit parameters, some cannot.
> 
> This is exactly what this patch tries to solve... I already mark those
> with a DEFAULTABLE flag.

It is not solving it, if you were solving it you would make all qdisc's
capable of being default instead of giving them what is essentially
"this is broken" flag.
> I wish I never mention that crash, which leads you to think I am trying
> to fix a crash rather than a more important issue, usability. See below.
> 
> Forget about the crash, consider the current behavior:
> 
> # echo htb > default_qdisc
> # succeed without any error
> (then add a root qdisc and remove it)
> # failure shown here in dmesg
> 
> And compare it with the behavior after my patch:
> 
> # echo htb > default_qdisc
> Invalid arguments
> 
> I think this is clearly an improvement.

Long term it's the wrong fix, trust me.

If you fix it properly, by making every qdisc capable of being ->init()'d
without explicit parameters, it will be the best behavior overall.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html