[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAM_iQpWscW+F4pnDXwn6uVsyaxVrYmUL6c8YF4wam29Lb4SVvg@mail.gmail.com>
Date: Thu, 27 Aug 2015 15:47:55 -0700
From: Cong Wang <xiyou.wangcong@...il.com>
To: David Miller <davem@...emloft.net>
Cc: Linux Kernel Network Developers <netdev@...r.kernel.org>,
Jamal Hadi Salim <jhs@...atatu.com>,
Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to
inappropriate ones
On Thu, Aug 27, 2015 at 3:42 PM, David Miller <davem@...emloft.net> wrote:
>
> Long term it's the wrong fix, trust me.
So we have plan to convert some non-defaultable qdisc to defaultable?
I don't see a reason here.
>
> If you fix it properly, by making every qdisc capable of being ->init()'d
> without explicit parameters, it will be the best behavior overall.
The problem is ->init() is not even called when setting it as default,
since setting a default qdisc doesn't need to create a qdisc. This is
why the flag has to be in ops->flags rather than qdisc->flags.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists