lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150827.161719.2292798105218631656.davem@davemloft.net>
Date:	Thu, 27 Aug 2015 16:17:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Woojung.Huh@...rochip.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/1] lan78xx: Change default internal PHY ID
 to 1

From: <Woojung.Huh@...rochip.com>
Date: Thu, 27 Aug 2015 18:01:17 +0000

> Change default internal PHY ID to 1.
> 
> Signed-off-by: Woojung Huh <woojung.huh@...rochip.com>

This doesn't describe in enough details, this change.

Why is this being changed now?  How did the driver work properly with
the previous value?  If it worked previously, what negative things
could possibly happen using the new value?

You are providing zero context, and reasoning, for your change.  That
makes it impossible to review.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ