netdev - RE: [PATCH net-next 1/1] lan78xx: Change default internal PHY ID to 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9235D6609DB808459E95D78E17F2E43D54C7B2@CHN-SV-EXMX02.mchp-main.com>
Date:	Fri, 28 Aug 2015 01:25:52 +0000
From:	<Woojung.Huh@...rochip.com>
To:	<davem@...emloft.net>
CC:	<netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 1/1] lan78xx: Change default internal PHY ID to
 1

Sorry for lack of details.

Default PHY ID is changed to 1 for final silicon.
This is an coding error to be included.

________________________________________
From: David Miller [davem@...emloft.net]
Sent: Thursday, August 27, 2015 7:17 PM
To: Woojung Huh - C21699
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/1] lan78xx: Change default internal PHY ID to 1

From: <Woojung.Huh@...rochip.com>
Date: Thu, 27 Aug 2015 18:01:17 +0000

> Change default internal PHY ID to 1.
>
> Signed-off-by: Woojung Huh <woojung.huh@...rochip.com>

This doesn't describe in enough details, this change.

Why is this being changed now?  How did the driver work properly with
the previous value?  If it worked previously, what negative things
could possibly happen using the new value?

You are providing zero context, and reasoning, for your change.  That
makes it impossible to review.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html