netdev - Re: [PATCH] net-sysfs: get_netdev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55F33781.1030405@gmail.com>
Date:	Fri, 11 Sep 2015 13:20:17 -0700
From:	John Fastabend <john.fastabend@...il.com>
To:	Thadeu Lima de Souza Cascardo <cascardo@...hat.com>,
	netdev@...r.kernel.org
CC:	Or Gerlitz <ogerlitz@...lanox.com>,
	John Fastabend <john.r.fastabend@...el.com>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH] net-sysfs: get_netdev_queue_index() cleanup

On 15-09-11 01:08 PM, Thadeu Lima de Souza Cascardo wrote:
> Redo commit ed1acc8cd8c22efa919da8d300bab646e01c2dce.
> 
> Commit 822b3b2ebfff8e9b3d006086c527738a7ca00cd0 ("net: Add max rate tx queue
> attribute") moved get_netdev_queue_index around, but kept the old version.
> Probably because of a reuse of the original patch from before Eric's change to
> that function.
> 
> Remove one inline keyword, and no need for a loop to find
> an index into a table.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...hat.com>
> Fixes: 822b3b2ebfff8e9b3d006086c527738a7ca00cd0
> Cc: Or Gerlitz <ogerlitz@...lanox.com>
> Cc: John Fastabend <john.r.fastabend@...el.com>
> Cc: Eric Dumazet <edumazet@...gle.com>
> ---
> 
> Not sure what is the best way to credit Eric Dumazet here. I assume he will add
> any appropriate tags.
> 

Yep, I guess Or just overlooked this and I missed it in the review when
the patch was submitted.

Thanks!

Acked-by: John Fastabend <john.r.fastabend@...el.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html