netdev - Re: [PATCH] net-sysfs: get_netdev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55F50DB2.4080009@mellanox.com>
Date:	Sun, 13 Sep 2015 08:46:26 +0300
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	Thadeu Lima de Souza Cascardo <cascardo@...hat.com>
CC:	<netdev@...r.kernel.org>,
	John Fastabend <john.r.fastabend@...el.com>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH] net-sysfs: get_netdev_queue_index() cleanup

On 9/11/2015 11:08 PM, Thadeu Lima de Souza Cascardo wrote:
> Redo commit ed1acc8cd8c22efa919da8d300bab646e01c2dce.
>
> Commit 822b3b2ebfff8e9b3d006086c527738a7ca00cd0 ("net: Add max rate tx queue
> attribute") moved get_netdev_queue_index around, but kept the old version.
> Probably because of a reuse of the original patch from before Eric's change to
> that function.
>
> Remove one inline keyword, and no need for a loop to find
> an index into a table.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...hat.com>
> Fixes: 822b3b2ebfff8e9b3d006086c527738a7ca00cd0

Please use here a --abbrev=12 generated short log e.g

Fixes: 22b3b2ebfff ('net: Add max rate tx queue attribute')

> Cc: Or Gerlitz <ogerlitz@...lanox.com>

remove the Cc: line for me and add this one (hate to see myself 
mentioned twice here...)

Acked-by:  Or Gerlitz <ogerlitz@...lanox.com>

Good catch!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html