netdev - Re: [patch net-next RFC 3/6] rocker: switch to local transaction phase enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150920085920.GC2203@nanopsycho.orion>
Date:	Sun, 20 Sep 2015 10:59:20 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, idosch@...lanox.com,
	eladr@...lanox.com, sfeldma@...il.com, f.fainelli@...il.com,
	linux@...ck-us.net
Subject: Re: [patch net-next RFC 3/6] rocker: switch to local transaction
 phase enum

Sat, Sep 19, 2015 at 09:25:04PM CEST, vivien.didelot@...oirfairelinux.com wrote:
>Hi Jiri,
>
>On Sep. Saturday 19 (38) 02:29 PM, Jiri Pirko wrote:
>> Since switchdev_trans_ph anum is going to be removed, and rocker code is
>> way too complicated in this matter to be converted, just introduce local
>> enum for transaction phase. Pass it around in local transaction
>> structure.
>
>I missed this typo here: s/anum/enum/.
>
>> Signed-off-by: Jiri Pirko <jiri@...nulli.us>
>
>I found the renaming trick is a bit hard to follow. I am wondering if
>this patch could be used first and drop patch 1/6?
>
>That way, you can first add the rocker_trans structure and set its ph
>member to obj->trans in obj_add/attr_set, then the following patch
>(currently 2/6) would just assign it to the new trans parameter.

That could work locally for rocker, but for the rest of the code, I
belive it would not. Anyway, the result would be the same.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html