netdev - Re: [PATCH v2] netpoll: Close race condition between poll_one_napi and napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150922150920.2a830e62@urahara>
Date:	Tue, 22 Sep 2015 15:09:20 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Neil Horman <nhorman@...hat.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2] netpoll: Close race condition between poll_one_napi
 and napi_disable

On Tue, 22 Sep 2015 16:01:36 -0400
Neil Horman <nhorman@...hat.com> wrote:

> +	clear_bit(NAPI_STATE_NPSVC, &n->state);
> +
>  }
why introduce extra line here?

> +	/*
> +	 * If we set this bit but see that it has already been set,
> +	 * that indicates that napi has been disabled and we need
> +	 * to abort this operation
> + 	 */
> +
> +	if(test_and_set_bit(NAPI_STATE_NPSVC, &napi->state))

And why introduce line after comment before code.
My preference is to have comment as close to code as possible.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html