netdev - Re: [PATCH v2] netpoll: Close race condition between poll_one_napi and napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150923.110310.498137907112491653.davem@davemloft.net>
Date:	Wed, 23 Sep 2015 11:03:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nhorman@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2] netpoll: Close race condition between poll_one_napi
 and napi_disable

From: Neil Horman <nhorman@...hat.com>
Date: Tue, 22 Sep 2015 16:01:36 -0400

> -	set_bit(NAPI_STATE_NPSVC, &napi->state);
> +	/*
> +	 * If we set this bit but see that it has already been set,
> +	 * that indicates that napi has been disabled and we need
> +	 * to abort this operation
> + 	 */
> +
> +	if(test_and_set_bit(NAPI_STATE_NPSVC, &napi->state))
> +		goto out;
>  

Networking comments should be styled:

	/* Like
	 * this.
	 */

Also you need a space after the "if" and before the openning parenthesis.

And like Stephen I think the empty line between the comment and the
if() statement is superfluous and eats up precious vertical space on
the screen :-)

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html