netdev - Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1443033714.74600.18.camel@infradead.org>
Date:	Wed, 23 Sep 2015 19:41:54 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Jeremy Linton <jeremy.linton@....com>,
	linux-arm-kernel@...ts.infradead.org
Cc:	netdev@...r.kernel.org, steve.glendinning@...well.net,
	rafael.j.wysocki@...el.com, grant.likely@...aro.org,
	Suravee.Suthikulpanit@....com, Catalin.Marinas@....com
Subject: Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

On Wed, 2015-08-12 at 17:06 -0500, Jeremy Linton wrote:
> 
>  
> +static const struct acpi_device_id smsc911x_acpi_match[] = {
> +       { "ARMH9118", 0 },
> +       { }
> +};
> +MODULE_DEVICE_TABLE(acpi, smsc911x_acpi_match);
> +
>  static struct platform_driver smsc911x_driver = {
>         .probe = smsc911x_drv_probe,
>         .remove = smsc911x_drv_remove,
> @@ -2661,6 +2656,7 @@ static struct platform_driver smsc911x_driver =
> {
>                 .name   = SMSC_CHIPNAME,
>                 .pm     = SMSC911X_PM_OPS,
>                 .of_match_table = of_match_ptr(smsc911x_dt_ids),
> +               .acpi_match_table = ACPI_PTR(smsc911x_acpi_match),
>         },
>  };

Hm, surely you shouldn't need this part? If the ACPI device has a HID
of PRP0001, and an appropriate "compatible" property, then it ought to
be loaded anyway. If that doesn't work, we should fix that.

-- 
dwmw2


Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5691 bytes)