netdev - Re: [PATCH net] fib_rules: fix fib rule dumps across multiple skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150924.152230.1137654723404286423.davem@davemloft.net>
Date:	Thu, 24 Sep 2015 15:22:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	roopa@...ulusnetworks.com
Cc:	tgraf@...g.ch, netdev@...r.kernel.org, wkok@...ulusnetworks.com
Subject: Re: [PATCH net] fib_rules: fix fib rule dumps across multiple skbs

From: Roopa Prabhu <roopa@...ulusnetworks.com>
Date: Tue, 22 Sep 2015 21:40:22 -0700

> From: Wilson Kok <wkok@...ulusnetworks.com>
> 
> dump_rules returns skb length and not error.
> But when family == AF_UNSPEC, the caller of dump_rules
> assumes that it returns an error. Hence, when family == AF_UNSPEC,
> we continue trying to dump on -EMSGSIZE errors resulting in
> incorrect dump idx carried between skbs belonging to the same dump.
> This results in fib rule dump always only dumping rules that fit
> into the first skb.
> 
> This patch fixes dump_rules to return error so that we exit correctly
> and idx is correctly maintained between skbs that are part of the
> same dump.
> 
> Signed-off-by: Wilson Kok <wkok@...ulusnetworks.com>
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html